fix(ui5-option): add down/active state on press#13428
Open
NakataCode wants to merge 1 commit intomainfrom
Open
fix(ui5-option): add down/active state on press#13428NakataCode wants to merge 1 commit intomainfrom
NakataCode wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13428--ui5-webcomponents-preview.netlify.app |
plamenivanov91
requested changes
Apr 24, 2026
Contributor
plamenivanov91
left a comment
plamenivanov91
left a comment
There was a problem hiding this comment.
Can we achieve the target design CSS only?
/* Current */
:host([active][actionable]:not([data-moving])) {
background-color: var(--sapList_Active_Background);
border-bottom-color: var(--sapList_Active_Background);
}
/* Instead, use CSS :active */
:host(:active[actionable]:not([data-moving])) {
background-color: var(--sapList_Active_Background);
border-bottom-color: var(--sapList_Active_Background);
}
Without introducing JS overhead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce visual active/pressed state for
ui5-optionandui5-option-custominside ui5-select. When the user presses and holds on an option in the dropdown, the item reflects the active state usingsapList_Active_Background, matching the Fiori design spec for interactive list states._onmousedownhandler to Option and OptionCustommouseup/touchendlisteners in onEnterDOM to deactivateonMouseDownandonTouchStartvia injectedProps in ListItemBaseTemplateborder-bottom-colorin active state to match background (ListItemBase.css)JsxTemplatetype for listItemContent hook in ListItemBaseTemplateFixes: #13307